Team4388/2018-Robot
1
0
Fork 0
mirror of https://github.com/Team4388/2018-Robot.git synced 2026-06-08 16:28:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

hpe-code-Review

Browse Source 
add TODO's and changed 1 button on smart dash.
This commit is contained in:
lukesta182
2018-11-16 10:45:17 -08:00
parent 02285e5af3
commit 4d290a7142
4 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/org/usfirst/frc4388/robot/OI.java
+1 -3
View File
@@ -1,6 +1,4 @@
//TODO clean up white space
package org.usfirst.frc4388.robot; package org.usfirst.frc4388.robot;
import buttons.XBoxTriggerButton; import buttons.XBoxTriggerButton;
src/org/usfirst/frc4388/robot/Robot.java
-1
View File
@@ -140,7 +140,6 @@ public class Robot extends IterativeRobot
LRautonTaskChooser = new SendableChooser<Command>(); LRautonTaskChooser = new SendableChooser<Command>();
LRautonTaskChooser.addDefault("Choose LR Program", new CrossTheBaseLine()); LRautonTaskChooser.addDefault("Choose LR Program", new CrossTheBaseLine());
LRautonTaskChooser.addObject("Left to Left Switch", new LeftSwitchAuton()); LRautonTaskChooser.addObject("Left to Left Switch", new LeftSwitchAuton());
LRautonTaskChooser.addObject("Right to 2 Cube Scale", new Cube2Right()); LRautonTaskChooser.addObject("Right to 2 Cube Scale", new Cube2Right());
src/org/usfirst/frc4388/robot/subsystems/Carriage.java
+1 -1
View File
@@ -1,4 +1,4 @@
//TODO move constants to 1 folder
// RobotBuilder Version: 2.0 // RobotBuilder Version: 2.0
// //
// This file was generated by RobotBuilder. It contains sections of // This file was generated by RobotBuilder. It contains sections of
src/org/usfirst/frc4388/robot/subsystems/Drive.java
+3 -3
View File
@@ -221,7 +221,7 @@ public class Drive extends Subsystem implements ControlLoopable
//leftDrive1.setVoltageRampRate(VOLTAGE_RAMP_RATE); //leftDrive1.setVoltageRampRate(VOLTAGE_RAMP_RATE);
//leftDrive1.setNominalClosedLoopVoltage(12.0); //leftDrive1.setNominalClosedLoopVoltage(12.0);
leftDrive1.clearStickyFaults(0); leftDrive1.clearStickyFaults(0);
leftDrive1.setInverted(false);//false on comp 2108, false on microbot leftDrive1.setInverted(true);//false on comp 2108, false on microbot, true on practice chasis
leftDrive1.setSensorPhase(true);//true on comp 2108, false on microbot leftDrive1.setSensorPhase(true);//true on comp 2108, false on microbot
leftDrive1.setSafetyEnabled(false); leftDrive1.setSafetyEnabled(false);
//leftDrive1.setCurrentLimit(15); //leftDrive1.setCurrentLimit(15);
@@ -238,7 +238,7 @@ public class Drive extends Subsystem implements ControlLoopable
// } // }
leftDrive2.setInverted(false);//false on comp 2108, false on microbot leftDrive2.setInverted(true);//false on comp 2108, false on microbot, true on practice chasis
leftDrive2.setSafetyEnabled(false); leftDrive2.setSafetyEnabled(false);
leftDrive2.setNeutralMode(NeutralMode.Brake); leftDrive2.setNeutralMode(NeutralMode.Brake);
leftDrive2.set(ControlMode.Follower, leftDrive1.getDeviceID()); leftDrive2.set(ControlMode.Follower, leftDrive1.getDeviceID());
@@ -630,7 +630,7 @@ public class Drive extends Subsystem implements ControlLoopable
// m_steerInput = // m_steerInput =
// OI.getInstance().getDriveTrainController().getRightXAxis(); // OI.getInstance().getDriveTrainController().getRightXAxis();
m_moveInput = -OI.getInstance().getDriverController().getLeftYAxis(); m_moveInput = -OI.getInstance().getDriverController().getLeftYAxis();
m_steerInput = OI.getInstance().getDriverController().getRightXAxis(); m_steerInput = /*only negitive on chasis bot*/-OI.getInstance().getDriverController().getRightXAxis();
if (controlMode == DriveControlMode.JOYSTICK) { if (controlMode == DriveControlMode.JOYSTICK) {
m_moveOutput = adjustForSensitivity(m_moveScale, m_moveTrim, m_moveOutput = adjustForSensitivity(m_moveScale, m_moveTrim,