From d8e35e77df459adb8aa1a71cc6a8dfb5e06303a8 Mon Sep 17 00:00:00 2001 From: ryan123rudder <42309874+ryan123rudder@users.noreply.github.com> Date: Fri, 21 Feb 2020 21:11:43 -0700 Subject: [PATCH] Requested reviews --- src/main/java/frc4388/robot/subsystems/Intake.java | 4 ++-- src/main/java/frc4388/robot/subsystems/Storage.java | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/main/java/frc4388/robot/subsystems/Intake.java b/src/main/java/frc4388/robot/subsystems/Intake.java index d6b9b32..cbcd617 100644 --- a/src/main/java/frc4388/robot/subsystems/Intake.java +++ b/src/main/java/frc4388/robot/subsystems/Intake.java @@ -55,7 +55,7 @@ public class Intake extends SubsystemBase { * Runs intake motor * @param input the percent output to run motor at */ - public void runIntake(final double input) { + public void runIntake(double input) { m_intakeMotor.set(input); } @@ -63,7 +63,7 @@ public class Intake extends SubsystemBase { * Runs extender motor * @param input the percent output to run motor at */ - public void runExtender(final double input) { + public void runExtender() { if (m_extenderForwardLimit.get()) { isExtended = true; } diff --git a/src/main/java/frc4388/robot/subsystems/Storage.java b/src/main/java/frc4388/robot/subsystems/Storage.java index 5a7c7a0..3d460fe 100644 --- a/src/main/java/frc4388/robot/subsystems/Storage.java +++ b/src/main/java/frc4388/robot/subsystems/Storage.java @@ -42,7 +42,6 @@ public class Storage extends SubsystemBase { */ public Storage() { resetEncoder(); - boolean botReached = false; m_beamSensors[0] = new DigitalInput(StorageConstants.BEAM_SENSOR_DIO_0); m_beamSensors[1] = new DigitalInput(StorageConstants.BEAM_SENSOR_DIO_1); m_beamSensors[2] = new DigitalInput(StorageConstants.BEAM_SENSOR_DIO_2); @@ -62,7 +61,7 @@ public class Storage extends SubsystemBase { * @param input the voltage to run motor at */ - public void runStorage(final double input) { + public void runStorage(double input) { m_storageMotor.set(input); }